Activity (RSS)

There's no way to whitelist individual methods so they don't contribute to the class size. There's also no way to increase the size threshold on a per-class bas...

Given an ActiveRecord model with a number of validations and associations added, and no extra methods, the method count can balloon to larger than the max count...

If a Source is created from an IO stream or a String or an object, it should not attempt to look for *.reek config files. Currently the code looks in '.', which...

Thanks for spotting this!

Well there's a chunk of duplication in that code: every call to property (where is that defined, btw?) is embedded in a call to class_eval. So one option would ...

Wow! That was fast!

Thanks.

Resolved in release 1.0.1, available from github.com/kevinrutherford/reek

(from [f2caf4a0df265eba818f3c071ea96df597f4478e]) SourceList now has a ReportList [#36 state:resolved] http://github.com/kevinrutherfor...

The documentation is correct; this is a defect in SourceList. Its #report method should return an object that behaves like a Report.

According to rdoc: Reek::Source::from_pathlist(paths) Factory method: creates a Source object from an array of file paths. No source code is actually parsed unt...

Can you simply extract the outer block's body into a new method?

Works for me. :) Thanks!

There is already another way to do what you want:

dir = Dir['lib/**/*.rb'].to_source
dir.report.should have_at_most(85).smells

Not quite so sugary, perhap...

I considered that, but Dir['nice/*/type/.glob'].to_s is quite atrocious. A good specdoc is important to me. ;-)

so, if you made the 'reek' and 'reek_of' matcher...

please ignore the several typos in there (mismatched 'do...end', klass/klass_or_location). That's the downside of not having a 'preview' button. ;-)

I can see w...

Cool -- I'm on it this weekend. One smell tweak, while we're sketching code:

# specific classes or directories that we've cleaned up completely
[
  NewClas...

Absolutely. I like that a lot. I'm envisioning something like the following:

# specific smells we've cleaned up *everywhere*
describe "our codebase" do
  [...

I'm quite reluctant to add numerical theshholds for smells. But here's an alternative thought:

require 'my_class'

describe MyClass do
  it 'reports no co...

The $stderr warnings are from the underlying Ruby parser. (So they're smells too :).

I'd say that UncommunicativeName and Duplication are the easiest to remove ...

And yes, like you said... I'll probably start with smaller directories down the tree, rather than all of app and lib (as in my example).

That's also a good ratchet-like approach. Unfortunately, our codebase seems to collect all of the smells. ;-) I think I'll use that approach for some of them......

How about starting with

Dir[...].should_not reek_of(:UncommunicativeName)

for some smallish Dir down the tree?

agree with the second version:

some_source.should_not reek_much(:maximum_smells => 4400)
# or an alternate syntax:
some_source.should_not reek.more_than(44...

Resolved in v0.3.1.4