Activity (RSS)

Resolved at tag v0.3.1.3, except for Dir matchers (see #32).

Peeled off the Dir part into #32, because it requires a bit of a rethink about design of reports and such.

When solved, this should probably also become the implementation of Reek::RakeTask.

(Via Ashley Moran)

It would be really nice to have a spec matcher for Dirs and FileLists, such as:

Dir["lib/**/*.rb"].should smell_of(:FeatureEnvy)

So I envisage usages such as this:

it 'should recognise different bad names' do
  code = "def x(z) y + z; end"
  code.should smell_of(:UncommunicativeName,...

Code such as

"def x() y + z; end".should smell_of(:UncommunicativeName, /x/)

would check that the report contained an instance of UncommunicativeName, and ...

Provide one or matchers for rspec, so that users can write examples such as this:

"def simple?() true; end".should_not smell
"def x() y + z; end".should sme...

(from [211822c8676ca5fe1717f04a8fd248c0f73defef]) More tests for :: scoping [#29 state:resolved] http://github.com/kevinrutherfor...

Yes, I'll add some more factory methods to Source. In a few days...

(from [198d556de6bf4f26f9084900e812e209a799a106]) Reads source code from $stdin when no files specified [#25 state:resolved] http://github.com/kevinrutherfor.....

Fixed the scoping of class names in commit e476c5.

Code such as

class A::B::C; end

or

def Fred::meth; end

breaks the scoping rules in StopContext

(from [09de77b4e1a0e048f0936a19626122cc2e7570fc]) Fixed false reports of FeatureEnvy [#28 state:resolved] http://github.com/kevinrutherfor...

Defect has appeared because recent version of ParseTree now renders local method calls differently.

In this case I believe the reports of Feature Envy are all fallacious. This is a defect.

"app/models".should_not reek

is very sexy. Is

"app/models/**/*.rb".should_not reek

any less so?

Closed, because there are already a couple of viable alternatives.

In fact this is what Reek 0.2 used to do and I took it out. Let's do some design. If a commandline argument is a directory Reek should look at:

• all files calle...

From Ashley Moran, via email:

"Any chance you could make it take directories?"

I added the option to treat arguments as source so that tests were easy to write. But on reflection I do prefer the idea of reading from stdin when no files are...

From Ashley Moran, via email:

"Not sure I like the way you pass ruby source on the command line. Maybe a separate option would work, eg

% reek --ruby "def hello...