Activity (RSS)

Moved to the rrwb project

Russ suggests a new section type - "When to Leave It Alone".

There's at least one case in the duplication chapter where this makes sense. I'll try it where I ca...

(from [607e68eec56b325b3e64762aa2ad9103c993ee91]) Fixed LargeClass when checking unloaded module [#24 state:resolved] http://github.com/kevinrutherfor...

When Reek attempts to analyse the following code:

module Fred
  class Jim
  end
end

it crashes with *undefined method const_defined?' for nil:NilClass*.

...to 'exclude' or 'ignore'

Fixed in a8a4b41

Fixed in commit a8a4b41

Agree this would be nicer.

Right now, reek doesn't see the source code -- and therefore it can't see comments either. The config file was the simplest alternati...

better formatting for example...

def my_method #:nosmell[utility_function]
  ...
end

would be nice to be able to disable smells for specific bits of code instead of using the config file. for example...

def my_method #:nosmell[utility_function] ...

The LongMethod detector checks explicitly whether the method is called 'initialize'. This should move into defaults.reek.

The defaults file should be generated from the code of the smell detectors, to avoid duplication and the risk of inadvertent disconnects.

(See commit db83f4, wh...

Can the same regexes be used to discern any kind of uncommunicative name? Or should modules have one set, methods another, variables another, etc...?

Some tasks/*.rake are okay, because they let the gem user run the tests.

/tasks is in there too!

/website shouldn't be part of the gem package. Remove it from the manifest.

Set a configurable threshold, probably initialised to 10?