nicholas a. evans

Works for me. :) Thanks!

I considered that, but Dir['nice/*/type/.glob'].to_s is quite atrocious. A good specdoc is important to me. ;-)

so, if you made the 'reek' and 'reek_of' matcher...

please ignore the several typos in there (mismatched 'do...end', klass/klass_or_location). That's the downside of not having a 'preview' button. ;-)

I can see w...

Absolutely. I like that a lot. I'm envisioning something like the following:

# specific smells we've cleaned up *everywhere*
describe "our codebase" do
  [...

And yes, like you said... I'll probably start with smaller directories down the tree, rather than all of app and lib (as in my example).

That's also a good ratchet-like approach. Unfortunately, our codebase seems to collect all of the smells. ;-) I think I'll use that approach for some of them......

agree with the second version:

some_source.should_not reek_much(:maximum_smells => 4400)
# or an alternate syntax:
some_source.should_not reek.more_than(44...